Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix etcd startup #1269

Closed

Conversation

Confushion
Copy link
Contributor

After applying the fix for issue #1206, timing/race issues were still showing when creating etcd clusters with more than 1 instance.

This patch fixes the race condition by having etcdadm-reconfigure.service depend on service var-lib-etcd2.mount instead of format-etcd2-volume.service (var-lib-etcd2.mount already depends on that service).

Also a potential circulair dependency on cfn-etcd-environment.service has been eliminated.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2018
@Confushion Confushion closed this May 1, 2018
@Confushion Confushion deleted the fix_etcd_startup branch May 1, 2018 22:41
@Confushion
Copy link
Contributor Author

Closed PR, committed with wrong username. Use PR #1270 instead.

@codecov-io
Copy link

Codecov Report

Merging #1269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   36.63%   36.63%           
=======================================
  Files          63       63           
  Lines        3882     3882           
=======================================
  Hits         1422     1422           
  Misses       2242     2242           
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185ccc5...a4f1a9a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants