This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Experimental feature: User-specified node labels for worker nodes #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.90% (diff: 100%)@@ master #149 diff @@
==========================================
Files 4 4
Lines 1095 1103 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 763 771 +8
Misses 248 248
Partials 84 84
|
|
@pieterlange I'm willing to rename the former The former |
This complements Node Pools(kubernetes-retired#46) and Spot Fleet support(kubernetes-retired#112) The former `experimental.nodeLabel` configuration key is renamed to `experimental.awsNodeLabels` to avoid collision with newly added `experimental.nodeLabels` and consistency with `experimental.awsEnvironment`.
mumoshu
force-pushed
the
user-specified-node-labels
branch
from
e0a62bb
to
f2beccf
Compare
This was referenced Dec 14, 2016
Closed
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…-node-labels Experimental feature: User-specified node labels for worker nodes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements Node Pools(#46) and Spot Fleet support(#112)
The former
experimental.nodeLabelconfiguration key is renamed toexperimental.awsNodeLabelsto avoid collision with newly addedexperimental.nodeLabelsand consistency withexperimental.awsEnvironment.cc @pieterlange @c-knowles