This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Added an option to Skip IOPS verification in ETCD #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When provisioning ETCDs with EBS volumes and provisioned IOPS the default check will wait for a full monitorization of the EBS volume. This actually checks two things, io-enabled and io-performance (See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-volume-status.html) The io-performance checks that the EBS volume is actually able to deliver the provisioned IOPS. Since it is based on cloudwatch it is very slow and usually takes more than 5m to be passed. Since I have to constantly create and destroy clusters (sometimes with 3 or more ETCD nodes) I can save more than 15m per cluster with this flag
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
- Coverage 24.59% 24.58% -0.01%
==========================================
Files 98 98
Lines 5071 5072 +1
==========================================
Hits 1247 1247
- Misses 3684 3685 +1
Partials 140 140
Continue to review full report at Codecov.
|
Fsero
approved these changes
Jan 28, 2020
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provisioning ETCDs with EBS volumes and provisioned IOPS
the default check will wait for a full monitorization of the EBS
volume. This actually checks two things, io-enabled and io-performance
(See
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-volume-status.html)
The io-performance checks that the EBS volume is actually able to deliver
the provisioned IOPS. Since it is based on cloudwatch it is very slow
and usually takes more than 5m to be passed. The other check, io-enabled, is usually quite fast.
Since I have to constantly create and destroy clusters (sometimes with 3
or more ETCD nodes) I can save more than 15m per cluster skiping the io-performance verification and trusting io-enabled.