Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.12.x] Flatcar #1856

Merged
merged 5 commits into from
May 27, 2020
Merged

Conversation

jorge07
Copy link
Contributor

@jorge07 jorge07 commented May 25, 2020

In this PR:

  • Replace Flatcar for 0.12.x branch
  • Created ReleaseChannel model to keep logic outside config
  • Introduces a cmd to get latests AmiID for the cluster.yaml configuration. Example:
➜ kube-aws ami
The Flatcar AmiId for region us-east-1 and release channel stable is different than the one in cluster definition.

Cluster.yaml:
- amiId: ami-04e51eabc8abea762
+ amiId: ami-011655f166912d5ba

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2020
@dominicgunn
Copy link
Contributor

Hey @jorge07,

Is your team still actively using v0.12.x? I'm hesistant to merge & create a release unless you are.

@jorge07
Copy link
Contributor Author

jorge07 commented May 26, 2020

Yes we do. We've some clusters in 0.12.x where the upgrade to 0.13.x didn't end well, so we maintain 0.12.x branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1856 into v0.12.x will decrease coverage by 0.09%.
The diff coverage is 5.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.12.x    #1856      +/-   ##
===========================================
- Coverage    38.19%   38.09%   -0.10%     
===========================================
  Files           75       76       +1     
  Lines         4658     4667       +9     
===========================================
- Hits          1779     1778       -1     
- Misses        2633     2643      +10     
  Partials       246      246              
Impacted Files Coverage Δ
core/nodepool/config/config.go 34.49% <ø> (ø)
flatcar/amiregistry/amiregistry.go 0.00% <0.00%> (ø)
flatcar/amiregistry/reliable_http.go 86.36% <ø> (ø)
model/release_channel.go 0.00% <0.00%> (ø)
core/controlplane/config/config.go 63.24% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea4367...a5d83c3. Read the comment docs.

@dominicgunn dominicgunn changed the title 0.12.x Flatcar [v0.12.x] Flatcar May 27, 2020
@dominicgunn
Copy link
Contributor

Got it, thanks for the PR.

@dominicgunn dominicgunn added this to the v0.12.7 milestone May 27, 2020
@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@dominicgunn dominicgunn merged commit d268c5a into kubernetes-retired:v0.12.x May 27, 2020
@jorge07 jorge07 deleted the 0.12.x-flartcar branch May 27, 2020 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants