Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.1] Fix rendering for openICMP #1867

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

dominicgunn
Copy link
Contributor

@dominicgunn dominicgunn commented May 29, 2020

Changes

Rendering for the new openICMP feature was broken when more than one addressed was assigned to sshAccessAllowedSourceCIDRs, this fixes it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 29, 2020
@dominicgunn dominicgunn changed the title [v0.16.x] Fix rendering for openICMP [v0.16.1] Fix rendering for openICMP May 29, 2020
@dominicgunn dominicgunn added this to the v0.16.1 milestone May 29, 2020
@dominicgunn dominicgunn changed the base branch from master to v0.16.x May 29, 2020 14:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #1867 into v0.16.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.16.x    #1867   +/-   ##
========================================
  Coverage    24.41%   24.41%           
========================================
  Files           98       98           
  Lines         5116     5116           
========================================
  Hits          1249     1249           
  Misses        3727     3727           
  Partials       140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43cd06...ba4664d. Read the comment docs.

@dominicgunn dominicgunn merged commit f2781f8 into v0.16.x Jun 1, 2020
@cblecker cblecker deleted the feature/v0.16.1-fix-openicmp-rendering branch September 30, 2020 16:26
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants