This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Upgrade heapster to version 1.3.0 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 38.53% 38.53%
=======================================
Files 30 30
Lines 2351 2351
=======================================
Hits 906 906
Misses 1324 1324
Partials 121 121
Continue to review full report at Codecov.
|
danielfm
suggested changes
Mar 18, 2017
AlmogBaku
force-pushed
the
heapster-1.3.0
branch
from
c4c6e2d
to
552667e
Compare
|
@danielfm thanks. fixed. |
|
Also, if I may suggest, instead of keeping the hard-coded version in the template, like this: metadata:
name: heapster-v1.2.0... why not use the tag from the config, like this: metadata:
name: heapster-{{.HeapsterImage.Tag}}I did not test this though, but it seems possible to get rid of this duplication here. |
|
Thanks for the help @AlmogBaku @danielfm! Btw, @danielfm's suggested improvement sounds great. Would you mind submitting an another github issue for that? |
22 tasks
camilb
added a commit
to camilb/kube-aws
that referenced
this pull request
Apr 5, 2017
* kubernetes-incubator/master: (29 commits) Emit errors when kube-aws sees unexpected keys in cluster.yaml Resolves kubernetes-retired#404 Tag controller nodes appropriately with `kubernetes.io/role`. Resolves kubernetes-retired#370 Make Container Linux AMI fetching a bit more reliable Stop locksmithd errors on etcd nodes Upgrade heapster to version 1.3.0 (kubernetes-retired#420) Auth token file support (kubernetes-retired#418) Update README.md Update README accordingly to the new git repo AWS China region support (kubernetes-retired#390) Conform as a Kubernetes Incubator Project Fixed typo in template upgrade aws-sdk to latest version Fix kubernetes-retired#388 Upgrade Kubernetes version to v1.5.4 Fix assumed public hostnames for EC2 instances in us-east-1 Fix assumed public hostnames for EC2 instances in us-east-1 typo fix: etcdDataVolumeEncrypted not creating encrypted volumes fixes kubernetes-retired#383 Allow disabling wait signals fixes kubernetes-retired#371 Update file paths in readme Fix an issue with glue security group documentation ...
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade heapster to version 1.3.0