This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Let subns with propagated objects be deleted #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue kubernetes-retired#1130. The HNC object validator was preventing the K8s namespace controller from cleaning out a namespace to allow it to be deleted. This change lets HNC understand that when a namespace is being deleted, we should ignore the subnamespaceOf annotation. This allows the HierarchyConfiguration object to be reset to its initial state (like a full namespace would when it's being deleted), orphaning the namespace and allowing all its propagated objects to be removed. Tested: added new tests and ran them multiple times while watching the logs. The subnamespace test failed without this change and passed every time with it, with the logs showing the expected behaviour.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
NB: I'm currently running all e2e tests on this patch; I'll remove my hold when they all pass. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/approve assuming the e2e tests pass |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
All e2e tests passed, including the new ones. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1130. The HNC object validator was preventing the K8s
namespace controller from cleaning out a namespace to allow it to be
deleted. This change lets HNC understand that when a namespace is being
deleted, we should ignore the subnamespaceOf annotation. This allows the
HierarchyConfiguration object to be reset to its initial state (like a
full namespace would when it's being deleted), orphaning the namespace
and allowing all its propagated objects to be removed.
Tested: added new tests and ran them multiple times while watching the
logs. The subnamespace test failed without this change and passed every
time with it, with the logs showing the expected behaviour.
Fixes #1130