This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Create minimial v1a2 to v1a1 converters #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating another issue, I looked at the logs from the K8s apiserver and observed that we were seeing tons of errors as the apiserver asked HNC to convert the v1a2 objects back to v1a1 - specifically, that their names has changed. I have no idea why K8s is asking for these objects to be backconverted, but after glancing at the K8s source code, I guessed that copying the object metadata would work to fix the issue, and it did. Tested: observed no more logspam from the apiserver
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @yiqigao217 |
adrianludwin
added a commit
to adrianludwin/multi-tenancy
that referenced
this pull request
Sep 30, 2020
This change fixes todos in the cherrypick for kubernetes-retired#1150 (see issue kubernetes-retired#1149). It simplifies and restructures a lot of the logic to make it easier to follow while looking at less data (e.g. a lot more focus on anchor.Status.State). It also adds a lots more documentation. Tested: all e2e tests pass on GKE 1.18 when combined with fixes to the e2e tests (PRs kubernetes-retired#1160, kubernetes-retired#1162, kubernetes-retired#1163 and kubernetes-retired#1164).
adrianludwin
added a commit
to adrianludwin/multi-tenancy
that referenced
this pull request
Sep 30, 2020
This change fixes todos in the cherrypick for kubernetes-retired#1150 (see issue kubernetes-retired#1149). It simplifies and restructures a lot of the logic to make it easier to follow while looking at less data (e.g. a lot more focus on anchor.Status.State). It also adds a lots more documentation. Tested: all e2e tests pass on GKE 1.18 when combined with fixes to the e2e tests (PRs kubernetes-retired#1160, kubernetes-retired#1162, kubernetes-retired#1163 and kubernetes-retired#1164).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating another issue, I looked at the logs from the K8s
apiserver and observed that we were seeing tons of errors as the
apiserver asked HNC to convert the v1a2 objects back to v1a1 -
specifically, that their names has changed. I have no idea why K8s is
asking for these objects to be backconverted, but after glancing at the
K8s source code, I guessed that copying the object metadata would work
to fix the issue, and it did.
Tested: observed no more logspam from the apiserver