This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Fix Prometheus metrics #1211
Merged
Fix Prometheus metrics #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the global Prometheus registry, but controller-runtime (now?) uses its own, separate registry. This change uses controller-runtime's registry instead. This change also uses the most recent OpenCensus Prometheus exporter and removes a bunch of dead code, including direct access of the Prometheus golang client. As a result, there are a bunch of changes in the vendor directory. Tested: directly inspected the /metrics endpoint on the HNC pod via wget. Without this change, none of the custom HNC metrics are included; with this change, they are.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @yiqigao217 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the global Prometheus registry, but controller-runtime
(now?) uses its own, separate registry. This change uses
controller-runtime's registry instead.
This change also uses the most recent OpenCensus Prometheus exporter and
removes a bunch of dead code, including direct access of the Prometheus
golang client. As a result, there are a bunch of changes in the vendor
directory.
Tested: directly inspected the /metrics endpoint on the HNC pod via
wget. Without this change, none of the custom HNC metrics are included;
with this change, they are.