This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
HNC v0.6 docs: conditions and configuration #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @yiqigao217 We only need one lgtm for this. |
|
/hold Need to make sure these work with @yiqigao217 's changes |
k8s-ci-robot
added
do-not-merge/hold
adrianludwin
force-pushed
the
doc-updates
branch
from
2934b3b to
f34f46f
Compare
k8s-ci-robot
removed
the
needs-rebase
adrianludwin
force-pushed
the
doc-updates
branch
2 times, most recently
from
de493e2 to
5e3740c
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
adrianludwin
force-pushed
the
doc-updates
branch
from
5e3740c to
33863f8
Compare
yiqigao217
reviewed
Oct 27, 2020
Update the docs for the latest in condition schemas; make some slight tweaks to the resource config section and explain how to bypass the overwrite protection. Tested: staged at https://github.com/adrianludwin/multi-tenancy/tree/doc-updates/incubator/hnc/docs/user-guide.
adrianludwin
force-pushed
the
doc-updates
branch
from
33863f8 to
9c23b6c
Compare
|
/lgtm Anyone can cancel the hold. |
k8s-ci-robot
added
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs for the latest in condition schemas; make some slight
tweaks to the resource config section and explain how to bypass the
overwrite protection.
Tested: staged at
https://github.com/adrianludwin/multi-tenancy/tree/doc-updates/incubator/hnc/docs/user-guide.
Fixes #1172, fixes #1181