This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Update controller-runtime to v0.7.0 #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
approved
Also updates to the latest (post-v0.1.0) version of cert-controller, which has a minor API change and supports controller-runtime v0.7.0. This commit doesn't include any changes except to react to API changes in controller-runtime and cert-controller. Tested: e2e tests on GKE 1.19
|
/assign @GinnyJI |
|
/lgtm /hold |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates to the latest (post-v0.1.0) version of cert-controller,
which has a minor API change and supports controller-runtime v0.7.0.
This commit doesn't include any changes except to react to API changes
in controller-runtime and cert-controller.
Tested: e2e tests on GKE 1.19
Fixes #1327
Fixes #1270