Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Update docs for upcoming v0.8 #1496

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

adrianludwin
Copy link
Contributor

@adrianludwin adrianludwin commented Apr 29, 2021

Add documentation for excluded namespaces and remove references to HNC
v0.6.

Fixes #1466

Interesting modified files include:

@adrianludwin adrianludwin added this to the hnc-v0.8 milestone Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@adrianludwin
Copy link
Contributor Author

Hey, may I please get a quick lgtm on this so I can branch for v0.8?

/assign @yiqigao217
/assign @rjbez17

@adrianludwin adrianludwin marked this pull request as draft April 29, 2021 16:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2021
@adrianludwin
Copy link
Contributor Author

Actually hang on a sec, I'll update the docs for #1466 as well.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2021
@adrianludwin adrianludwin force-pushed the docs-v08 branch 2 times, most recently from 8961fa8 to d53e6fb Compare April 29, 2021 17:24
@adrianludwin adrianludwin marked this pull request as ready for review April 29, 2021 17:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2021
@adrianludwin
Copy link
Contributor Author

Ok this is ready. Sorry for the spam!

Copy link
Contributor

@yiqigao217 yiqigao217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 nits

incubator/hnc/docs/user-guide/how-to.md Outdated Show resolved Hide resolved
incubator/hnc/docs/user-guide/how-to.md Show resolved Hide resolved
Add documentation for excluded namespaces and remove references to HNC
v0.6.
Copy link
Contributor

@yiqigao217 yiqigao217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3964a2f into kubernetes-retired:master Apr 29, 2021
@adrianludwin adrianludwin deleted the docs-v08 branch April 30, 2021 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HNC: Add excluded namespace configuration to v0.8 release note and installation note.
4 participants