This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Add all controller metrics #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @adrianludwin |
yiqigao217
force-pushed
the
hnc-opentelemetry
branch
2 times, most recently
from
fdba1c5 to
af2be0b
Compare
yiqigao217
force-pushed
the
hnc-opentelemetry
branch
from
af2be0b to
1b39f15
Compare
This commit adds metrics of HierConfig and all other object controllers. It includes total reconciliations and peak concurrent reconciliations and related api writes. Tested on GKE cluster and the metrics can all be viewed in Stackdriver.
yiqigao217
force-pushed
the
hnc-opentelemetry
branch
from
1b39f15 to
712a106
Compare
|
lgtm! |
|
🎉 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjbez17, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds metrics of HierConfig and all other object controllers.
It includes total reconciliations and peak concurrent reconciliations
and related api writes.
Tested on GKE cluster and the metrics can all be viewed in Stackdriver.