Dynamically create object reconcilers for new types. #424

sophieliu15 · 2020-02-14T18:23:52Z

This PR creates object reconciler(s) when new type(s) are added to the
HNCConfiguration and informs the hierarchy reconciler about the new
object reconciler(s).

Specifically, it does the following tasks:

Dynamically creates an object reconciler when a new type is added
in HNCConfiguration.
Informs the hierarchy reconciler about the newly added object
reconciler so the corresponding objects can be propagated correctly
when the hierarchy structure changes.

Test: Verified on a GKE cluster that

When adding a new type in HNCConfiguration, corresponding object
reconciler is created successfully.
When adding a new object of the same type to a node in the namespace
tree, the object is propagated correctly to the descendants of the
node.
When the tree structure changes (e.g., add another descendant to the
node above), the new object of the same type is propagated
correctly.

Design doc: http://bit.ly/hnc-type-configuration
Issue: #411

k8s-ci-robot · 2020-02-14T18:24:00Z

Hi @sophieliu15. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adrianludwin · 2020-02-14T18:32:50Z

/assign @rjbez17

Note that this change will also stop syncing everything except Roles and RoleBindings by default.

adrianludwin

lgtm

incubator/hnc/pkg/controllers/config_controller.go

incubator/hnc/pkg/forest/forest.go

adrianludwin · 2020-02-14T18:49:04Z

/ok-to-test

incubator/hnc/pkg/controllers/config_controller.go

sophieliu15 · 2020-02-14T21:34:28Z

The test should be fixed by now. Feel free to take a look.

adrianludwin · 2020-02-17T13:39:26Z

incubator/hnc/pkg/controllers/object_controller_test.go

+		// Add secret to HNCConfiguration so that an ObjectReconciler will be created for secret.
+		addSecretToHNCConfig(ctx, hncConfig)
+


These should all be in the BeforeEach function at the top of this file.

Good point. Done.

incubator/hnc/pkg/forest/forest.go

rjbez17 · 2020-02-18T15:23:43Z

This lgtm, @adrianludwin and @yiqigao217 are you satisfied with the updates from you last few comments? Feel free to remove hold when happy.

/assign @adrianludwin
/assign @yiqigao217

/lgtm
/approve
/hold

adrianludwin · 2020-02-18T15:23:39Z

incubator/hnc/pkg/controllers/object_controller_test.go

-var _ = Describe("Secret", func() {
+var _ = Describe("Role", func() {


Didn't we switch this back to "Secret" now?

Good catch! Switched back to "Secret".

adrianludwin · 2020-02-18T15:24:56Z

Thanks Ryan! Just one minor nit left then I'll remove the hold.

This PR creates object reconciler(s) when new type(s) are added to the HNCConfiguration and informs the hierarchy reconciler about the new object reconciler(s). Specifically, it does the following tasks: - Dynamically creates an object reconciler when a new type is added in HNCConfiguration. - Informs the hierarchy reconciler about the newly added object reconciler so the corresponding objects can be propagated correctly when the hierarchy structure changes. Test: Verified on a GKE cluster that - When adding a new type in HNCConfiguration, corresponding object reconciler is created successfully. - When adding a new object of the same type to a node in the namespace tree, the object is propagated correctly to the descendants of the node. - When the tree structure changes (e.g., add another descendant to the node above), the new object of the same type is propagated correctly.

adrianludwin

/lgtm
/unhold
/approve

k8s-ci-robot · 2020-02-18T15:52:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17, sophieliu15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2020

sophieliu15 requested a review from adrianludwin February 14, 2020 18:23

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2020

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2020

k8s-ci-robot requested review from Fei-Guo and rjbez17 February 14, 2020 18:24

sophieliu15 requested review from yiqigao217 and rjbez17 and removed request for rjbez17 and Fei-Guo February 14, 2020 18:24

k8s-ci-robot assigned rjbez17 Feb 14, 2020

adrianludwin reviewed Feb 14, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2020

yiqigao217 reviewed Feb 14, 2020

View reviewed changes

incubator/hnc/pkg/controllers/config_controller.go Show resolved Hide resolved

yiqigao217 reviewed Feb 14, 2020

View reviewed changes

incubator/hnc/pkg/controllers/config_controller.go Show resolved Hide resolved

sophieliu15 force-pushed the dynamic_start branch 5 times, most recently from 5f1b35e to d97b627 Compare February 14, 2020 21:31

adrianludwin reviewed Feb 17, 2020

View reviewed changes

sophieliu15 force-pushed the dynamic_start branch from d97b627 to 9d3f734 Compare February 18, 2020 14:56

k8s-ci-robot assigned adrianludwin and yiqigao217 Feb 18, 2020

k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2020

adrianludwin reviewed Feb 18, 2020

View reviewed changes

sophieliu15 force-pushed the dynamic_start branch from 9d3f734 to 123981b Compare February 18, 2020 15:47

k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020

adrianludwin reviewed Feb 18, 2020

View reviewed changes

k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 18, 2020

k8s-ci-robot merged commit 39df5a5 into kubernetes-retired:master Feb 18, 2020

sophieliu15 mentioned this pull request Mar 2, 2020

REQUEST: New membership for sophieliu15 kubernetes/org#1679

Closed

6 tasks

sophieliu15 deleted the dynamic_start branch March 6, 2020 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamically create object reconcilers for new types. #424

Dynamically create object reconcilers for new types. #424

sophieliu15 commented Feb 14, 2020

k8s-ci-robot commented Feb 14, 2020

adrianludwin commented Feb 14, 2020

adrianludwin left a comment

adrianludwin commented Feb 14, 2020

sophieliu15 commented Feb 14, 2020

adrianludwin Feb 17, 2020

sophieliu15 Feb 18, 2020

rjbez17 commented Feb 18, 2020

adrianludwin Feb 18, 2020

sophieliu15 Feb 18, 2020

adrianludwin commented Feb 18, 2020

adrianludwin left a comment

k8s-ci-robot commented Feb 18, 2020

		// Add secret to HNCConfiguration so that an ObjectReconciler will be created for secret.
		addSecretToHNCConfig(ctx, hncConfig)

		var _ = Describe("Secret", func() {
		var _ = Describe("Role", func() {

Dynamically create object reconcilers for new types. #424

Dynamically create object reconcilers for new types. #424

Conversation

sophieliu15 commented Feb 14, 2020

k8s-ci-robot commented Feb 14, 2020

adrianludwin commented Feb 14, 2020

adrianludwin left a comment

Choose a reason for hiding this comment

adrianludwin commented Feb 14, 2020

sophieliu15 commented Feb 14, 2020

adrianludwin Feb 17, 2020

Choose a reason for hiding this comment

sophieliu15 Feb 18, 2020

Choose a reason for hiding this comment

rjbez17 commented Feb 18, 2020

adrianludwin Feb 18, 2020

Choose a reason for hiding this comment

sophieliu15 Feb 18, 2020

Choose a reason for hiding this comment

adrianludwin commented Feb 18, 2020

adrianludwin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 18, 2020