Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Replace "controller" with "reconciler" in hnc/pkg/controllers directory #447

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Replace "controller" with "reconciler" in hnc/pkg/controllers directory #447

merged 1 commit into from
Feb 25, 2020

Conversation

sophieliu15
Copy link
Contributor

@sophieliu15 sophieliu15 commented Feb 24, 2020 •
edited
Loading

Replace "controller" with "reconciler" in hnc/pkg/controllers directory. "Controllers" can refer to both reconcilers and admission controllers. Since the controllers we implemented under hnc/pkg/controllers are actually reconcilers, using "reconciler" instead of "controller" would be more precise.

Design doc: http://bit.ly/hnc-type-configuration
Issue: #411

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sophieliu15. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2020
@sophieliu15 sophieliu15 removed the request for review from adrianludwin February 24, 2020 18:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@sophieliu15 sophieliu15 requested review from yiqigao217 and removed request for JimBugwadia February 24, 2020 18:40
@sophieliu15 sophieliu15 force-pushed the rename_controllers branch 2 times, most recently from d1ae668 to ba9cf0b Compare February 24, 2020 18:47
yiqigao217
yiqigao217 reviewed Feb 24, 2020
View reviewed changes
incubator/hnc/README.md Outdated

* **HNCConfiguration controller:** manages the HNCConfiguration via the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/controller/reconciler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated.

adrianludwin
adrianludwin reviewed Feb 24, 2020
View reviewed changes
incubator/hnc/go.sum Outdated
@@ -142,6 +142,7 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
github.com/kr/pty v1.1.5/go.mod h1:9r2w37qlBe7rQ6e1fg1S/9xpWHSnaqNdHD3WcMdbPDA=
github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
github.com/kubernetes-sigs/multi-tenancy v0.0.0-20200221171633-2b5c81967af0 h1:JzZCwDzWZpZOMNgir26AiVSDuCWsJSGB2CX5pzT2/fM=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right - this means it tried to download a package. Try reverting go.sum and re-running make to ensure it's not changed again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

incubator/hnc/pkg/reconcilers/config_reconciler.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020
@sophieliu15 sophieliu15 force-pushed the rename_controllers branch 2 times, most recently from c18c5ac to 5f83e7c Compare February 25, 2020 15:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2020
@sophieliu15 sophieliu15 force-pushed the rename_controllers branch 5 times, most recently from ab57534 to 13b4e0e Compare February 25, 2020 15:07
@sophieliu15
Replace "controller" with "reconciler" in hnc/pkg/controllers directory
5ddeece 
Replace "controller" with "reconciler" in hnc/pkg/controllers directory. "Controllers" can refer to both reconcilers and admission controllers. Since thecontrollers we implemented under hnc/pkg/controllers are actually reconcilers, using "reconciler" instead of "controller" would be more precise.
@adrianludwin
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, sophieliu15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit f017f03 into kubernetes-retired:master Feb 25, 2020
@sophieliu15 sophieliu15 mentioned this pull request Mar 2, 2020
Closed
6 tasks
@sophieliu15 sophieliu15 deleted the rename_controllers branch March 6, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yiqigao217 yiqigao217 yiqigao217 left review comments

@adrianludwin adrianludwin adrianludwin left review comments

Assignees

@adrianludwin adrianludwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophieliu15 @k8s-ci-robot @adrianludwin @yiqigao217