Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

use dl.k8s.io instead of hardcoded GCS URIs #188

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Jul 17, 2021

The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .)

Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us
as a project, since we can transparently change where that redirects to
without having to change code everywhere

These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release -> gs://k8s-release migration equivalent of
the CI migration we're going through right now

These changes also address the gs://kubernetes-release-dev references
currently used by this repo (ref:
kubernetes/k8s.io#2318)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spiffxp
To complete the pull request process, please assign m1093782566 after the PR has been reviewed.
You can assign the PR to them by writing /assign @m1093782566 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2021
@spiffxp
Copy link
Contributor Author

spiffxp commented Jul 17, 2021

@deepak-vij your tests appear to be broken, do you have time to look into that? I'm going to manually merge if this goes a few days with no comment

@k8s-ci-robot
Copy link
Contributor

@spiffxp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-poseidon-bazel 6be0340 link /test pull-poseidon-bazel
pull-poseidon-verify 6be0340 link /test pull-poseidon-verify
ci-poseidon-e2e-gce 6be0340 link /test ci-poseidon-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepak-vij
Copy link
Contributor

Hi @spiffxp, apologize for the inconvenience. Please go ahead and manually merge it at this time as you suggested earlier. We can also retire this project. Is this something I need to do that you folks can do it yourself. Please let me know. Thanks.

@spiffxp
Copy link
Contributor Author

spiffxp commented Jul 19, 2021

Use my admin privileges on this repo to merge this as requested

@spiffxp spiffxp merged commit 2c9fce1 into kubernetes-retired:master Jul 19, 2021
@spiffxp spiffxp deleted the use-dl-k8s-io branch July 19, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants