Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

ERROR: logging before flag.Parse in all log messages #1187

Closed
pmorie opened this issue Sep 1, 2017 · 3 comments
Closed

ERROR: logging before flag.Parse in all log messages #1187

pmorie opened this issue Sep 1, 2017 · 3 comments

Comments

@pmorie
Copy link
Contributor

pmorie commented Sep 1, 2017

Seriously annoying... debugging now.
@jboyd01
Copy link
Contributor

jboyd01 commented Sep 1, 2017

I ran across this kubernetes/kubernetes#17162 which has a simple work around but I've also seen that the glog.V(5).Infof() type messages are not displayed making me think something more basic (lack of initialization?) is happening.

@pmorie
Copy link
Contributor Author

pmorie commented Sep 1, 2017

I am pretty sure this snuck in with #1112

@jboyd01
Copy link
Contributor

jboyd01 commented Sep 1, 2017

FWIW, adding goflag.CommandLine.Parse([]string{}) at line 49 to controller_manager.go looks to address the logging in the controller. I also couldn't reproduce any problems with the glog.V(5).Infof() though I swear I was missing this logging last week.

@jboyd01 jboyd01 mentioned this issue Sep 7, 2017
Merged
@wallrj wallrj mentioned this issue Oct 31, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmorie @jboyd01