-
Notifications
You must be signed in to change notification settings - Fork 384
fix glog logging #1204
fix glog logging #1204
Conversation
we want to pick up the prior version to fix issue 1187.
c924db0
to
f9dbd4e
Compare
All set for review @pmorie. I reverted the code change and as we discussed, updated glide.yaml with the current sha1 from glide.lock for every package that lacked a version and changed glog to point to the previous version. I verified both API and Controller servers are logging correctly. |
Why should we prefer this over the workaround? |
@MHBauer i think anything that adds specificity to the glide yaml is beneficial. I would also like to not be on a version of glog that main k8s is on, and the workaround is really silly (since we don't use |
What? Why? |
@MHBauer i don't want to hit some random bug on a newer version of dependency than main k8s is. That's not the issue here, but that's my general feeling on the subject. |
Not being on a newer version of glog is okay. I'm fine with glide cleanup in general. I do not understand why we would we explicitly not sync with the same version of glog upstream-k8s has. EDIT: dash for clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jboyd01
LGTM
I think we might have a communication mismatch. This PR pins us to the version of glog k8s is on. |
@pmorie okay, fine with me. I'm not sure how I could interpret "I would also like to not be on a version of glog that main k8s is on" as meaning we want the same version of k8s, but okay. EDIT: indication that emphasis is mine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
didn't check that the version matching is true, but assuming good faith that it is.
Oops, I meant "isn't on" |
force go flag initialization to satisfy glog that cmd line parameters have been initialized. Fixes #1187
"ERROR: logging before flag.Parse" is prefacing all log entries for Catalog Controller and API servers.
Workaround pulled from kubernetes/kubernetes#17162.