Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

make e2e look for pods' existence before checking status #1012

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

kibbles-n-bytes
Copy link
Contributor

Fixes CI issue in #936 . The tests were assuming the pods existed before checking their status, but the changes in this PR seem to have slowed down the catalog chart installation enough that this assumption was failing consistently.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2017
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's asynchronous!

lgtm if it passes, and not if it doesn't. I'm not sure this is generally reproduce-able that we'll *know if it actually fixes it besides waiting and seeing in the future.

@MHBauer MHBauer added the LGTM1 label Jul 7, 2017
Copy link
Contributor

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. hopefully this is a step in the right direction to reduce flakes

@arschles arschles merged commit 91fa1ad into kubernetes-retired:master Jul 7, 2017
@kibbles-n-bytes kibbles-n-bytes deleted the jenkins branch July 11, 2017 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants