This repository has been archived by the owner on May 6, 2022. It is now read-only.
use GKE's default K8S version for Jenkins #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
arschles
reviewed
Jul 12, 2017
There was a problem hiding this comment.
@kibbles-n-bytes is it still possible to specify a GKE version? It'd be nice to do so forever, if possible, so that GKE changes don't necessarily break our build.
MHBauer
approved these changes
Jul 12, 2017
|
@arschles Not easily, because GKE seems to get rid of earlier patch versions in favor of later patches of the same minor version. That's why that code was necessary in the first place back then. But we can still add something more robust to give us, for instance, "the latest 1.6 that exists", but that should be as a followup. |
arschles
approved these changes
Jul 12, 2017
There was a problem hiding this comment.
Thanks @kibbles-n-bytes. Can you make an issue for the follow-up?
This was referenced Jul 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 1.5.X was still the default for GKE, we needed special code when initializing the test cluster so that we'd get the latest 1.6.X version. This code assumed that:
I just noticed that on the us-west1-a zone, 1.7.0 is the latest version and 1.6.4 is the default, meaning these two assumptions no longer hold, and Jenkins (which runs in the us-west1-b zone) is a ticking time bomb that is set to fail as soon as us-west1-b gets updated.
So for the time being, let's fix this to use the default version quickly (the default in us-west1-b is also 1.6.4), and then we can make a follow-up once time is on our side!