This repository has been archived by the owner on May 6, 2022. It is now read-only.
Tweaks to the walkthrough for local-up-cluster #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
sjenning
reviewed
Jul 31, 2017
docs/walkthrough.md
Outdated
| KUBE_ENABLE_CLUSTER_DNS=true hack/local-up-cluster.sh -O | ||
| ``` | ||
| ```console | ||
| KUBE_ENABLE_CLUSTER_DNS=true hack/local-up-cluster.sh -O |
There was a problem hiding this comment.
KUBE_ENABLE_CLUSTER_DNS=true is the default in kube now
MHBauer
reviewed
Jul 31, 2017
| - "--service-catalog-insecure-skip-verify=true" | ||
| {{- end }} |
There was a problem hiding this comment.
Overall question:
Do we need an issue to make sure every single flag is helm exposed?
MHBauer
approved these changes
Jul 31, 2017
| namespace has the `cluster-admin` role: | ||
|
|
||
| ```console | ||
| kubectl create clusterrolebinding default-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default |
There was a problem hiding this comment.
kubeadm sets up this level of access, and while I have to include the disclaimer that kubeadm is not production ready, I have to somewhat assume that a decision was made that this is the correct level of access.
An additional data point is that Bluemix does include this serviceAccount bound to this level of access.
pmorie
force-pushed
the
walkthrough-tweaks
branch
from
0498d76
to
e324287
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple tweaks were necessary for me to make the walkthrough run on a cluster created with
local-up-cluster.sh:kube-systemnamespace a cluster admin