-
Notifications
You must be signed in to change notification settings - Fork 387
Adding more small fixes to the walkthrough & install docs #1169
Adding more small fixes to the walkthrough & install docs #1169
Conversation
And declaring the abbreviation for “Certificate Authority”
docs/walkthrough-1.6.md
Outdated
@@ -277,9 +277,9 @@ ups-instance-credential Opaque 2 | |||
|
|||
Notice that a new `Secret` named `ups-instance-credential` has been created. | |||
|
|||
# Step 6 - Unbinding from the ServiceInstance | |||
# Step 6 - Deleting the `ServiceInstanceCredentials` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this is singular instead of plural
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
One nit and LGTM |
Thanks for the review @pmorie |
docs/walkthrough-1.6.md
Outdated
|
||
# Step 1 - Installing the UPS ServiceBroker | ||
# Step 1 - Installing the UPS Broker Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, isn't "Service Broker" more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even "Service Broker Server" if you're trying to be less OSB-API-y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do "Service Broker Server". I need to clearly differentiate it from the ServiceBroker
resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
Now, let's unbind from the instance. To do this, we simply *delete* the | ||
Now, let's unbind from the provisioned instance. To do this, we simply *delete* the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems inconsistent to use 'delete' in the title but 'unbind' in the text. I'm ok with either one, but we should be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duglin this document tries to equate Kubernetes actions (delete in this case) with the equivalent OSB concept (unbind in this case), so I kept with that trend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a newbie I would be confused by the switch in verbs, perhaps do something like:
Now, let's unbind from (delete) the provisioned instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no that's not right either....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip my comment - we can tweak it in a follow-on PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duglin if you'd like to switch the verbs around, I'm happy to do that. It'll require a change in the rest of the doc too, so how about we do that in a follow-up?
LGTM |
waiting on CI.... |
thanks @duglin |
This is a follow-up to #1163.