This repository has been archived by the owner on May 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 385
Specifying that you need Helm v2.5.0 for installation #1170
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,14 +27,14 @@ KUBE_ENABLE_CLUSTER_DNS=true hack/local-up-cluster.sh -O | |
|
||
## Helm | ||
|
||
You *must* use [Helm](http://helm.sh/) v2 or newer in the installation steps | ||
You *must* use [Helm](http://helm.sh/) v2.5.0 or newer in the installation steps | ||
below. | ||
|
||
If you already have Helm v2 or newer, execute `helm init` (if you haven't | ||
If you already have Helm v2.5.0 or newer, execute `helm init` (if you haven't | ||
already) to install Tiller (the server-side component of Helm), and you should | ||
be done with Helm setup. | ||
|
||
If you don't already have Helm v2, see the | ||
If you don't already have Helm v2.5.0, see the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "or newer" :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
[installation instructions](https://github.com/kubernetes/helm/blob/master/docs/install.md). | ||
|
||
If your kubernetes cluster has | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating the version 3 times in a single section looks a bit redundant to me, I would leave if only for the first mention and omit the version completely in all other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nilebox I've removed redundancy