-
Notifications
You must be signed in to change notification settings - Fork 387
Adding walkthrough instructions for 1.7 #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resource renames + one lingering context reference
docs/walkthrough-1.7.md
Outdated
`kubectl get` will return an empty list of resources. | ||
|
||
```console | ||
kubectl get brokers,serviceclasses,instances,bindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brokers
, instances
, bindings
-> servicebrokers
, serviceinstances
, servicebindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - thanks @kibbles-n-bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
Do so with the following command: | ||
|
||
```console | ||
kubectl --context=service-catalog create -f contrib/examples/walkthrough/ups-broker.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the context anymore here I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - thanks @kibbles-n-bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
The output of that command should be the following: | ||
|
||
```console | ||
broker "ups-broker" created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
We can check the status of the broker using `kubectl get`: | ||
|
||
```console | ||
kubectl get brokers ups-broker -o yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
Check the status of that process with this command: | ||
|
||
```console | ||
kubectl get instances -n test-ns ups-instance -o yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
`ServiceInstanceCredential` resource that we previously created: | ||
|
||
```console | ||
kubectl delete -n test-ns bindings ups-instance-credential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
`ServiceInstance` resource that we previously created: | ||
|
||
```console | ||
kubectl delete -n test-ns instances ups-instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/walkthrough-1.7.md
Outdated
command: | ||
|
||
```console | ||
kubectl delete brokers ups-broker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks for catching all the incorrect resource names @kibbles-n-bytes - I addressed all your comments. |
No problem. LGTM! |
docs/walkthrough-1.7.md
Outdated
# Step 1 - Installing the UPS Broker Server | ||
|
||
In order to effectively demonstrate the service catalog, we need a sample | ||
broker server. We've built a "dummy" server called the User Provided Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like 'we' changes value between sentences here, maybe I'm misreading things though. Is the second sentence better put as "to illustrate the concept of a broker, we'll use a "dummy" server" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I modified the wording to only use "we" to indicate the person running through the demo
@pmorie I addressed your comment. Can you take another look? |
2f3e2e0
to
7b5d7d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it's a little weird that we use the term 'ServiceInstanceCredential' with the bind/unbind verbs, but we can sort that out later.
This is a follow-up to #1163