Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Adding walkthrough instructions for 1.7 #1171

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

arschles
Copy link
Contributor

This is a follow-up to #1163

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2017
Copy link
Contributor

@kibbles-n-bytes kibbles-n-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resource renames + one lingering context reference

`kubectl get` will return an empty list of resources.

```console
kubectl get brokers,serviceclasses,instances,bindings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brokers, instances, bindings -> servicebrokers, serviceinstances, servicebindings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - thanks @kibbles-n-bytes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Do so with the following command:

```console
kubectl --context=service-catalog create -f contrib/examples/walkthrough/ups-broker.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the context anymore here I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - thanks @kibbles-n-bytes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

The output of that command should be the following:

```console
broker "ups-broker" created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

We can check the status of the broker using `kubectl get`:

```console
kubectl get brokers ups-broker -o yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Check the status of that process with this command:

```console
kubectl get instances -n test-ns ups-instance -o yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

`ServiceInstanceCredential` resource that we previously created:

```console
kubectl delete -n test-ns bindings ups-instance-credential
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

`ServiceInstance` resource that we previously created:

```console
kubectl delete -n test-ns instances ups-instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

command:

```console
kubectl delete brokers ups-broker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@arschles
Copy link
Contributor Author

Thanks for catching all the incorrect resource names @kibbles-n-bytes - I addressed all your comments.

@kibbles-n-bytes
Copy link
Contributor

No problem. LGTM!

# Step 1 - Installing the UPS Broker Server

In order to effectively demonstrate the service catalog, we need a sample
broker server. We've built a "dummy" server called the User Provided Service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like 'we' changes value between sentences here, maybe I'm misreading things though. Is the second sentence better put as "to illustrate the concept of a broker, we'll use a "dummy" server" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I modified the wording to only use "we" to indicate the person running through the demo

@arschles
Copy link
Contributor Author

@pmorie I addressed your comment. Can you take another look?

Copy link
Contributor

@pmorie pmorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it's a little weird that we use the term 'ServiceInstanceCredential' with the bind/unbind verbs, but we can sort that out later.

@pmorie pmorie added the LGTM2 label Aug 30, 2017
@pmorie pmorie merged commit 6036d4e into kubernetes-retired:master Aug 30, 2017
@arschles arschles deleted the walkthrough-1.7 branch August 30, 2017 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants