Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Migrate from glide to dep for dependency management #1670

Merged
merged 7 commits into from
Jan 25, 2018
Merged

Migrate from glide to dep for dependency management #1670

merged 7 commits into from
Jan 25, 2018

Commits on Jan 25, 2018

  1. dep init 

    * Resolve conflict for code.cloudfoundry.org/lager
  code.cloudfoundry.org/lager is required to be at 0bfa98e by
  github.com/pivotal-cf/brokerapi
  https://github.com/pivotal-cf/brokerapi/blob/35946a0079bda144d0c9ed68df36899451f90209/Gopkg.toml#L26

* Require code generators and build tools
  I had to change the constraint for repo-infra from a pinned revision
  to latest on master. I was running into dependency hell otherwise. Can revisit if
  necessary.
    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    569b6d7 View commit details
    Browse the repository at this point in the history

  2. Sync vendor to Gopkg.lock 

    * Ignoring large doc files in GoLLRB
    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    b6d9801 View commit details
    Browse the repository at this point in the history

  3. Validate vendor and dep config during build 

    * Add test-dep target
  Validates that a downstream consumer of our client library can use dep
* Add verify-vendor target
  Validates that what is in vendor/ is in sync with Gopkg.lock
* Install dep in the docker build image
    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    84dc591 View commit details
    Browse the repository at this point in the history

  4. Update relevant glide usage to dep 

    We cannot completely remove glide because we are using
`glide nv`. If we had a requirement of Go 1.9+ maybe that could
be dropped, since the go tools in that version don't include
vendor anymore with `./...`, but until then it needs to stay.
    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    d044fb6 View commit details
    Browse the repository at this point in the history

  5. Remove glide config files in favor of dep's

    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    69f4a53 View commit details
    Browse the repository at this point in the history

  6. Skip dep's cache during href checking

    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    a30db90 View commit details
    Browse the repository at this point in the history

  7. Remove native dep targets 

    They don't work because GOPATH is redefined in the Makefile
So people will just have to rely on the docker, or install dep themselves.
    @carolynvs-msft
    carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    6be0903 View commit details
    Browse the repository at this point in the history