Add option to automatically deploy the Broker resource with the sample broker app #980

luxas · 2017-06-25T17:36:40Z

No-op.
Just makes the chart automatically create the Broker object; convenient since the Chart knows how to talk to the ups-broker service.

Currently this is in an example, and assumes you've installed things in a certain fashion.
With this it's easy to just assume that when you install the broker using the chart, you get the Broker registration for free

pmorie

I'm fine with this, one ask

pmorie · 2017-06-27T06:43:38Z

charts/ups-broker/values.yaml

@@ -3,3 +3,5 @@
 image: quay.io/kubernetes-service-catalog/user-broker:v0.0.11
 # ImagePullPolicy; valid values are "IfNotPresent", "Never", and "Always"
 imagePullPolicy: Always
+# Specifies whether to deploy the Broker service-catalog object for this Deployment
+deployBroker: true


Can we call this deployBrokerResource instead?

luxas · 2017-06-28T12:13:34Z

@pmorie Fixed, PTAL

luxas · 2017-07-06T06:54:57Z

ping @pmorie

arschles · 2017-07-06T21:34:40Z

charts/ups-broker/templates/broker.yaml

+  name: ups-broker
+spec:
+  url: http://{{ template "fullname" . }}.{{ .Release.Namespace }}.svc.cluster.local
+{{ end }}


I am all for this, but it won't work unless the service-catalog API server is run behind the aggregator. Can you document that please?

pmorie · 2017-07-13T06:02:03Z

I'm all for this, but it depends on the API server being run behind the aggregator. I'd like to hold this until the aggregator is setup by default for the default path through the walkthrough.

luxas · 2017-07-13T09:06:31Z

@pmorie Ok, let's wait for that... I hope that's going to be soon given @arschles', @MHBauer's and my PRs for that feature

luxas · 2017-07-17T20:42:13Z

@pmorie Ok now when the aggregator stuff merged?

vaikas · 2017-08-16T22:56:57Z

charts/ups-broker/README.md

@@ -36,6 +36,7 @@ Service Broker
 |-----------|-------------|---------|
 | `image` | Image to use | `quay.io/kubernetes-service-catalog/user-broker:v0.0.11` |
 | `imagePullPolicy` | `imagePullPolicy` for the ups-broker | `Always` |
+| `deployBrokerResource` | Whether the `Broker` Service Catalog resource should be automatically created or not | `true` |


Could we change the Broker -> User Provided Service Broker
or UPS Broker.
Broker resource is very generic.

vaikas · 2017-08-16T23:06:39Z

charts/ups-broker/values.yaml

@@ -3,3 +3,5 @@
 image: quay.io/kubernetes-service-catalog/user-broker:v0.0.11
 # ImagePullPolicy; valid values are "IfNotPresent", "Never", and "Always"
 imagePullPolicy: Always
+# Specifies whether to deploy the Broker service-catalog object for this Deployment
+deployBrokerResource: true


Can we change this to deployUPSBroker
I personally think it would be better to drop the Resource from the name, but the biggest thing missing is the fact that it's UPS broker specifically.

pmorie · 2017-09-25T20:37:06Z

@luxas this is getting stale - will you rebase it or close it? Thanks

ps: happy birthday

k8s-ci-robot · 2017-10-07T21:11:23Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

…e broker app

luxas · 2017-10-07T21:33:51Z

@pmorie Cool. Now got back to this (finally!)
PTAL and merge

kibbles-n-bytes · 2018-01-04T23:10:22Z

charts/ups-broker/README.md

@@ -36,6 +36,7 @@ Service Broker
 |-----------|-------------|---------|
 | `image` | Image to use | `quay.io/kubernetes-service-catalog/user-broker:v0.0.23` |
 | `imagePullPolicy` | `imagePullPolicy` for the ups-broker | `Always` |
+| `deployUPSBroker` | Whether the `User Provided Service Broker` Service Catalog resource should be automatically created or not. Requires running behind the aggregator. | `true` |


The values.yaml defaults to false, but this says the default is true.

nilebox · 2018-02-19T08:41:03Z

@luxas do you want to address the @kibbles-n-bytes's review comment and finally merge it?

luxas · 2018-05-11T20:08:01Z

Sorry don't have bandwidth to rebase again. If you want this patch, pls carry it for me.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2017

pmorie reviewed Jun 27, 2017

View reviewed changes

luxas force-pushed the deploy_broker branch from f22994f to 4f42c68 Compare June 28, 2017 12:13

luxas mentioned this pull request Jul 6, 2017

Cleaning up the setup instructions for Kubernetes 1.7 #1005

Closed

arschles reviewed Jul 6, 2017

View reviewed changes

vaikas reviewed Aug 16, 2017

View reviewed changes

luxas force-pushed the deploy_broker branch from 4f42c68 to 4dcc0f5 Compare October 7, 2017 21:11

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2017

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2017

luxas force-pushed the deploy_broker branch 2 times, most recently from c348d24 to 6aa7476 Compare October 7, 2017 21:16

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2017

Add option to automatically deploy the Broker resource with the sampl…

8bcbc56

…e broker app

luxas force-pushed the deploy_broker branch from 6aa7476 to 8bcbc56 Compare October 7, 2017 21:19

kibbles-n-bytes reviewed Jan 4, 2018

View reviewed changes

luxas closed this May 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to automatically deploy the Broker resource with the sample broker app #980

Add option to automatically deploy the Broker resource with the sample broker app #980

luxas commented Jun 25, 2017

pmorie left a comment

pmorie Jun 27, 2017

luxas commented Jun 28, 2017

luxas commented Jul 6, 2017

arschles Jul 6, 2017

pmorie commented Jul 13, 2017

luxas commented Jul 13, 2017

luxas commented Jul 17, 2017

vaikas Aug 16, 2017

vaikas Aug 16, 2017

pmorie commented Sep 25, 2017

k8s-ci-robot commented Oct 7, 2017

luxas commented Oct 7, 2017

kibbles-n-bytes Jan 4, 2018

nilebox commented Feb 19, 2018

luxas commented May 11, 2018

Add option to automatically deploy the Broker resource with the sample broker app #980

Add option to automatically deploy the Broker resource with the sample broker app #980

Conversation

luxas commented Jun 25, 2017

pmorie left a comment

Choose a reason for hiding this comment

pmorie Jun 27, 2017

Choose a reason for hiding this comment

luxas commented Jun 28, 2017

luxas commented Jul 6, 2017

arschles Jul 6, 2017

Choose a reason for hiding this comment

pmorie commented Jul 13, 2017

luxas commented Jul 13, 2017

luxas commented Jul 17, 2017

vaikas Aug 16, 2017

Choose a reason for hiding this comment

vaikas Aug 16, 2017

Choose a reason for hiding this comment

pmorie commented Sep 25, 2017

k8s-ci-robot commented Oct 7, 2017

luxas commented Oct 7, 2017

kibbles-n-bytes Jan 4, 2018

Choose a reason for hiding this comment

nilebox commented Feb 19, 2018

luxas commented May 11, 2018