Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all shell command #1011

Merged
merged 23 commits into from
Apr 8, 2024
Merged

Remove all shell command #1011

merged 23 commits into from
Apr 8, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Mar 29, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove all shell command in main container

standalone init container

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Standalone init container introduced, please update your yaml

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@huww98
remove pfs_stat_collector
f10587e 
it relies on docker, which should not work now.
@huww98
invoke dbfs_get_home_path.sh without shell
b313bd8
@huww98
dbfs: umount with mounter
fa6c441 
in the process removing shell usage
@huww98
invoke get_dbfs_mount_path without shell
d43f707
@huww98
dbfs: cleanup umountGlobalPath
c5ea9f2 
When we raise the minimum supported k8s version above 1.26,
we can drop the hack of unmount old staging path from NodeUnpublishVolume.
Instead, we unmount all the old path at startup, since kubelet will not
need it anymore. And duplicated mount point in data disk would not block
unstage volume.
@huww98
read dbfs version using procfs to access root mount namespace
a0747a8 
in the process removing shell usage
@huww98
ens: do not use shell to write sysfs
5fb3161 
in the process of remove shell usage

the same as commits 08b21bd and 41697e6 but for ens
@huww98
ens: replace GetDeviceByMntPoint with mount.GetDeviceNameFromMount
64af7f8 
in the process of remove shell usage

Note that the both functions return devtmpfs for volume device path

the same as commit 525a23d but for ens
@huww98
ens: remove duplicated function GetNvmeDeviceByVolumeID
2293d9b
@huww98
ens: remove duplicated function checkDeviceAvailable
50f926f
@huww98
disk/ens: don't check mounted before remove
6555a80 
Since os.Remove will fail on mount point.
@huww98
disk: replace utils.IsMounted with mounter.IsLikelyNotMountPoint
785a823 
in the process of remove shell usage
@huww98
ens: replace utils.IsMounted with mounter.IsLikelyNotMountPoint
ec100e4 
in the process of remove shell usage
@huww98
dbfs: use mount.CleanupMountPoint for NodeUnpublishVolume
fc12fae 
in the process of remove shell usage
@huww98
dbfs: replace utils.IsMounted with mounter.IsLikelyNotMountPoint
4c29419 
in the process of remove shell usage
@huww98
metric: use IsLikelyNotMountPoint to check for mounted
739e665 
in the process of remove shell usage
@huww98
call udevadm without shell
a4afaa4 
in the process of remove shell usage
@huww98
disk: check regular mountpoint at outside of IsMountPointRunv
1b7caaf 
in the process of remove shell usage
@huww98
remove dead code
002002b
@huww98
build an additional init image
ebbe6dd 
so that we are able to remove shell from main image eventually
@huww98
remove freezefs connector server
973d723
@huww98
remove shell usage in connector
01f3845 
use \0 to split args
@huww98
Merge remote-tracking branch 'origin/master' into rm-shell-2
f37d2b5 
resolved trival conflict in imports
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 29, 2024
@huww98 huww98 changed the title Rm shell 2 Remove all shell command Mar 29, 2024
@mowangdk
Copy link
Contributor

mowangdk commented Apr 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
@mowangdk
Copy link
Contributor

mowangdk commented Apr 8, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3d017c2 into kubernetes-sigs:master Apr 8, 2024
7 checks passed
@huww98 huww98 mentioned this pull request Apr 19, 2024
Open
@huww98 huww98 deleted the rm-shell-2 branch April 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees

@mowangdk mowangdk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huww98 @k8s-ci-robot @mowangdk