-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk/snapshot: wait for cut #1225
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8d54165
to
26a8d22
Compare
26a8d22
to
0cad968
Compare
0cad968
to
2967666
Compare
788d367
to
302f176
Compare
99f62af
to
4a15d5a
Compare
A central place for all disks pending status changes (attaching/detaching). Waiter will poll disk status in batch and wake up the caller if the status has changed. The motivation is reducing OpenAPI call count, to avoid triggering throttling, thus improve system throughput. Also include a simple fallback waiter to support multi-tanent use-case. Shared disk support is best effort, since we cannot create new shared disks for test now. Note: We have observed that after AttachDisk returns, the status remains Available for a short period, so don't rely on disk.Status in pred.
4a15d5a
to
b1c424c
Compare
should be reverted once we have a ecsClient that can refresh its credentials
and implementations for Disk and Snapshot
CSI expect us to return the latest info each time CreateSnapshot is called.
Also retrieves the latest info about the snapshot, e.g. readyToUse.
We have client token now, and we will not create multiple snapshots for one VS object. And we still always describe snapshot at least once, so we sill have the latest info about it.
b1c424c
to
bf4889c
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
CSI requires us to ensure the snapshot is cut before returning. Implementing this by describe the just created snapshot and ensure its CreationTime is set.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: