-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typo check #1314
Add typo check #1314
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c9444fa
to
0f4c720
Compare
How about using golangci-lint? It is also used by Kubernetes. |
I've found that golint-ci is limited in the number of errors it can scan, and I scan the kubernetes repository for a lot of issues using typos. for example:
|
OK, golangci-lint seems using a hard coded dictionary that records both correct and incorrect word, and it is not updated https://github.com/golangci/misspell/blob/master/words.go |
4de6e6e
to
7ea7c79
Compare
/retest |
7ea7c79
to
1ad60a0
Compare
1ad60a0
to
fc54ebf
Compare
fc54ebf
to
2d54d89
Compare
DISK_TAGED_BY_PLUGIN typo haven't been detected, config file configuration must be present |
cd73d87
to
907b069
Compare
907b069
to
363978d
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add typo check in github action
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: