-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: verify VolumeCapabilities #902
disk: verify VolumeCapabilities #902
Conversation
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a449a0b
to
90c22d1
Compare
90c22d1
to
a1f82ac
Compare
a1f82ac
to
51b3927
Compare
51b3927
to
fc2443b
Compare
I've modified this PR to NOT enable multi-attach automatically. Because that implies additional limits. |
fc2443b
to
170c33a
Compare
rebased for csi-sanity |
Reject CreateVolume if capability cannot be supported: MULTI_NODE_MULTI_WRITER and MULTI_NODE_SINGLE_WRITER for mount volumes. Require MultiAttach to be enabled in parameters if multi-node access is requested. We do not enable it automatically because multi-attach implies additional limits, which may be unexpected to user. Also implement the ValidateVolumeCapabilities controller RPC call.
170c33a
to
66a36fc
Compare
/auto-cc |
/lgtm Add e2e test later |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Reject CreateVolume if capability cannot be supported: MULTI_NODE_MULTI_WRITER
and MULTI_NODE_SINGLE_WRITER for mount volumes.
Require MultiAttach to be enabled in parameters if multi-node access is requested.
We do not enable it automatically because multi-attach implies additional limits,
which may be unexpected to user.
Also implement the ValidateVolumeCapabilities controller RPC call.
Which issue(s) this PR fixes:
Fixes CSI sanity case:
Special notes for your reviewer:
PVC with
volumeMode: Filesystem
andaccessModes: [ ReadWriteMany ]
will fail with this event:Warning ProvisioningFailed 2s (x3 over 3s) diskplugin.csi.alibabacloud.com_csi-provisioner-647f8bccfb-w22zq_d72ba154-98bf-4c6d-b276-8cb0120fcbbc failed to provision volume with StorageClass "csi-disk-essd-immediate": rpc error: code = InvalidArgument desc = Invalid parameters from input: disk-ebddaed2-f256-4d6b-8855-785a1072fc11, with error: multi-node writing is only supported for block volume
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: