-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: fix parameter checks in NewNodeServer #917
disk: fix parameter checks in NewNodeServer #917
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Welcome @dongjiang1989! |
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think this is intentional. |
@dongjiang1989 yep, you could help with the error message & constants name fix. thx~
|
Maybe constants defined @mowangdk PTAL |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Co-authored-by: 胡玮文 <huww98@outlook.com>
@mowangdk Please re-check. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongjiang1989, huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix parameter checks in NewNodeServer
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: