-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rootfs and ephemeral storage metrics #944
feat: add rootfs and ephemeral storage metrics #944
Conversation
Skipping CI for Draft Pull Request. |
bb48a2c
to
d7358b1
Compare
@@ -55,15 +55,20 @@ func newCSICollector(metricType string, driverNames []string) error { | |||
enabledDrivers[d] = struct{}{} | |||
} | |||
for _, reg := range registry { | |||
enabled := len(reg.RelatedDrivers) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a bit strange here, but I can't think of any other way.
Need to backport to v1.26-compatible branch |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mowangdk, tydra-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick #944 add rootfs and ephemeral storage metrics
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: