-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: fix config file leakage if VolumeDevice is detached from DeleteVolume #953
disk: fix config file leakage if VolumeDevice is detached from DeleteVolume #953
Conversation
check and cleanup .conf files when saving new one.
because it should always return false now
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manually tested. This is only reproducible when upgrade from 1.22 to 1.24, where the globalmount path changed. |
/ok-to-test |
} | ||
} | ||
} | ||
} | ||
|
||
volumeFile := path.Join(VolumeDir, volumeID+".conf") | ||
if err := ioutil.WriteFile(volumeFile, []byte(devicePath), 0644); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ioutil is deprecated, we need to change here later
@@ -715,6 +715,23 @@ func saveVolumeConfig(volumeID, devicePath string) error { | |||
if err := removeVolumeConfig(volumeID); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole logic base on VolumeDir
are strange , we will delete it eventually
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
disk: fix config file leakage if VolumeDevice is detached from DeleteVolume.
When kubelet restarts, it will call StageVolume again. and if the leakage does happen, we will detach and attach the disk again, because
IsDeviceUsedOthers
returns true, which is dangerous if the user of this disk is running.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: