perf(fuse): add/remove "used-by-pod" annotations on fuse pod when publishing/unpublishing

[AlbeeSo]

What type of PR is this?

What this PR does / why we need it:

add/remove annotations like used-by-pod/09ec7b80-71d1-4fe9-8fa1-ea234563b05a: "20240116195325" on fuse pod when publishing/unpublishing, to help users understand the mapping between application pods and fuse pods

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbeeSo
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[huww98]

I would recommend csi.alibabacloud.com/used-by-pod/namespace/pod-name as annotation name.

[huww98]

This annotation should always have the same result as kubectl describe pvc xxx now, right?

But if this is combined with #957 , consider:

1. Pod "a" start, fuse pod "fuse-a" start with used-by-pod/a
2. fuse pod "fuse-a" fail
3. Pod "b" start, fuse pod "fuse-b" start with used-by-pod/b
4. Pod "b" finished, then "fuse-b" is left with no used-by-pod

This seems OK.

[AlbeeSo]

This annotation should always have the same result as kubectl describe pvc xxx now, right?

But if this is combined with #957 , consider:

1. Pod "a" start, fuse pod "fuse-a" start with used-by-pod/a
2. fuse pod "fuse-a" fail
3. Pod "b" start, fuse pod "fuse-b" start with used-by-pod/b
4. Pod "b" finished, then "fuse-b" is left with no used-by-pod

This seems OK.

here is a small demo for fuse pod crash case:

1. create an app pod with oss pv, with a fuse pod csi.alibabacloud.com/used-by-pod-5c7af695-e754-4b5b-9f08-609a76f6eac2: "2024-01-18T20:45:02+08:00"
2. fuse pod crash by killing fuse daemon
3. create another app pod, fuse restart with annotation csi.alibabacloud.com/used-by-pod-c0e4839c-8f73-41de-99ad-e998cddbdaba: "2024-01-18T21:01:09+08:00"
4. pod 5c7af695-e754-4b5b-9f08-609a76f6eac2 need to restart even it is on pvc's used-by list.

[huww98]

I still have concerns about using UID in the user interface.

How about:

• label: csi.alibabacloud.com/namespace: "<namespace of pvc/pod>"
• annotation: csi.alibabacloud.com/used-by-pod: "<pod-name1>,<pod-name2>"

I know this is harder to implement, as we need to pull the old annotation to add new pod. But it may be more friendly to users.

csi.alibabacloud.com/used-by-pod-<pod name> have issue about the length limit on annotation name

[AlbeeSo]

I still have concerns about using UID in the user interface.

How about:

• label: csi.alibabacloud.com/namespace: "<namespace of pvc/pod>"
• annotation: csi.alibabacloud.com/used-by-pod: ","

I know this is harder to implement, as we need to pull the old annotation to add new pod. But it may be more friendly to users.

csi.alibabacloud.com/used-by-pod-<pod name> have issue about the length limit on annotation name

the point is we cannot get the pod name on unpublish stage unless we record it.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.