-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup /etc/csi-tool #958
cleanup /etc/csi-tool #958
Conversation
please use build/multi instead
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
189d99f
to
b172eb9
Compare
always use "yum install" for install or upgrade, because it can download dependencies.
b172eb9
to
e831f77
Compare
Type=forking | ||
RuntimeDirectory=csiplugin | ||
Type=simple | ||
RuntimeDirectory=csi-tool/connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two level of directory is required, because the inner one will be removed by systemd when the service is stopped/restarted. If we only have single level, the directory re-created on host and the one mounted into container will be different.
/ok-to-test |
/lgtm @tydra-wang ptal~ |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
/etc
is for config files, and is not suitable for socket, rpm package...connector: use runtime directory for socket
Also includes some cleanups, see commits.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: