-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: refined volume count detection #960
disk: refined volume count detection #960
Conversation
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8e30dbe
to
41e2c58
Compare
Volume count detection now also works for static PV. We detect whether a disk is managed by us by reading k8s node resource, instead of disk tag. This makes OpenAPI access on node mandatory by default. We cannot startup if we cannot access OpenAPI. set DISK_ALLOW_ALL_TYPE env to skip this. Also makes KUBE_NODE_NAME env mandatory.
add a new disk tag csi.alibabacloud.com/volume-name only set diskName if we are sure it is vaild to comply with CSI spec and pass CSI-sanity test
41e2c58
to
cc1bf3d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Volume count detection now also works for static PV.
We detect whether a disk is managed by us by reading k8s node resource, instead of disk tag.
This makes OpenAPI access on node mandatory. We cannot startup if we cannot access OpenAPI.
set DISK_ALLOW_ALL_TYPE env to skip this.
Also makes KUBE_NODE_NAME env mandatory.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: