-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: remove shell usage #989
Conversation
in the process of remove shell usage Note that the both functions return devtmpfs for volume device path
in the process of remove shell usage
in the process of remove shell usage
in the process of remove shell usage
in the process of remove shell usage
in the process of remove shell usage
in the process of remove shell usage
"but volume paths are still present on disk" error is not reported by kubelet since v1.21 at commit 80e9bd30ea9 (Automatically remove orphaned pod's dangling volumes)
in the process of remove shell usage
in the process of remove shell usage
in the process of remove shell usage
resolved conflicts about log.Log replacement in disk/nodeserver.go
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Only for the ease of running unit test during development
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
to increase efficiency, avoid injection.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: