-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use openapiv3 config in sample-apiserver #102
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
Welcome @takirala! |
Signed-off-by: Tamal Saha <tamal@appscode.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: takirala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Synced with #104 |
/lgtm |
/assign @pwittrock |
Ref: kubernetes/apiserver@3783e4a
apiserver
has required openapiv3 config since v0.27.x release - See https://github.com/kubernetes/apiserver/blob/v0.27.0/pkg/server/genericapiserver.go#L957-L960vs the v0.26.x release:
https://github.com/kubernetes/apiserver/blob/v0.26.13/pkg/server/genericapiserver.go#L873
After upgrading the apiserver to v0.27.x in #95 the upgrade broke the
sample-apiserver
. As of now, it is still possible to usesample-apiserver
by customizing it but it would be nice to make it work out of the box. This change updates the setter to use openapi v3 config.