Feat: Opt out from etcd healthcheck so that apiserver can run completely w/o etcd #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
nil etcd options
yue9944882
force-pushed
the
feat/opt-out-etcd-healthcheck
branch
from
a43bd40
to
032406c
Compare
yue9944882
commented
Apr 14, 2021
| @@ -115,7 +115,11 @@ func (o *WardleServerOptions) Config() (*apiserver.Config, error) { | |||
| return nil, fmt.Errorf("error creating self-signed certificates: %v", err) | |||
| } | |||
|
|
|||
| o.RecommendedOptions.Etcd.StorageConfig.Paging = utilfeature.DefaultFeatureGate.Enabled(features.APIListChunking) | |||
| // change: allow etcd options to be nil | |||
| // TODO: this should be reverted after rebasing sample-apiserver onto https://github.com/kubernetes/kubernetes/pull/101106 | |||
There was a problem hiding this comment.
should revert the change after kubernetes/kubernetes#101106 is merged in the upstream sample-apiserver
yue9944882
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #44
ref: kubernetes-sigs/apiserver-builder-alpha#583