Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Warning" LogLevel for LivenessProbe #1044

Closed
iusergii opened this issue Sep 6, 2021 · 8 comments · Fixed by #1054
Closed

"Warning" LogLevel for LivenessProbe #1044

iusergii opened this issue Sep 6, 2021 · 8 comments · Fixed by #1054
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@iusergii
Copy link

iusergii commented Sep 6, 2021

Is your feature request related to a problem?/Why is this needed
I'd like to have an option to turn LivenessProbe to "Warning" mode. Currently, it generates a message every 10 seconds. This creates a lot of entries in my logging system.

/feature

Describe the solution you'd like in detail
I'd like to have only warning, error messages in the log output.

Describe alternatives you've considered
I've tried set logLevel: 1 but this doesn't change the number of messages.

@nirmalaagash
Copy link
Contributor

@iusergii It looks like the message is from connection.go file which is being used by liveness-probe. I think you should try requesting this feature in here.

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Sep 9, 2021

@iusergii , can the issue you are facing with the livenessprobe sidecar be the same as kubernetes-csi/livenessprobe#110? livenessprobe sidecar unnecessary verbose logging is fixed in livenessprobe@v2.3.0, see kubernetes-csi/livenessprobe#110.

@ialidzhikov
Copy link
Contributor

/triage needs-information

@k8s-ci-robot k8s-ci-robot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Sep 9, 2021
@iusergii
Copy link
Author

@ialidzhikov , @nirmalaagash thank you, guys. Yes my concern was about socket info

I0910 05:56:18.037171       1 connection.go:153] Connecting to unix:///csi/csi.sock

Verified on livenessprobe@v2.3.0 and it doesn't have it. Shell we update default in helm chart?

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Sep 10, 2021

Verified on livenessprobe@v2.3.0 and it doesn't have it. Shell we update default in helm chart?

In general, we can update the default livenessprobe version to v2.3.0. You should be able to pass the liveness probe image as chart value, so the update of the livenessprobe container image should not be a blocker for you.

/remove triage/needs-information
/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2021
@ialidzhikov
Copy link
Contributor

/remove-triage needs-information

@k8s-ci-robot k8s-ci-robot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Sep 10, 2021
@iusergii
Copy link
Author

@ialidzhikov sure will do. It fixes my issue,
Just want to remove the image tag hardcode in the future to not miss new releases.

@alex88
Copy link

alex88 commented Nov 6, 2021

Should upgrading to v2.4.0 fix the Connecting to unix:///csi/csi.sock continuous logginig? In my case I keep getting the message

Nvm it seems to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants