Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] Update kubernetes-csi/livenessprobe #1054

Merged

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Sep 10, 2021

/kind feature

Fixes #1044

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: The label(s) kind/enhacement cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhacement

Fixes #1044

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@ialidzhikov
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2021
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from 6f5b0fd to 8e5cd2f Compare September 12, 2021 13:32
@ialidzhikov
Copy link
Contributor Author

/cc @wongma7

@vdhanan
Copy link
Contributor

vdhanan commented Sep 13, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2021
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from 8e5cd2f to ba6e020 Compare September 20, 2021 11:58
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 20, 2021
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from ba6e020 to 7ce102c Compare September 24, 2021 10:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2021
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from 7ce102c to 4bbeba9 Compare October 11, 2021 15:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2021
@ialidzhikov ialidzhikov requested a review from wongma7 October 11, 2021 15:55
@ialidzhikov
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2021
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from 4bbeba9 to bbf5336 Compare December 7, 2021 14:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2021
@ialidzhikov
Copy link
Contributor Author

Failures seem to be related to

/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/hack/e2e/csi-test-artifacts/bin/kops: line 1: `<?xml version="1.0" encoding="utf-8"?><Error><Code>ServerBusy</Code><Message>Egress is over the account limit.'
###
## Creating cluster test-cluster-23625.k8s.local with /home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/hack/e2e/csi-test-artifacts/test-cluster-23625.k8s.local.kops.yaml (dry run)
#
/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/hack/e2e/csi-test-artifacts/bin/kops: line 1: syntax error near unexpected token `<'
/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/hack/e2e/csi-test-artifacts/bin/kops: line 1: `<?xml version="1.0" encoding="utf-8"?><Error><Code>ServerBusy</Code><Message>Egress is over the account limit.'
make: *** [Makefile:168: test-e2e-multi-az] Error 2
+ EXIT_VALUE=2
+ set +o xtrace

cc @wongma7

@ialidzhikov
Copy link
Contributor Author

/assign @wongma7

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
from v2.2.0 to v2.4.0

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov force-pushed the update/csi-liveness-probe branch from bbf5336 to 32bd9ac Compare December 8, 2021 07:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
@ialidzhikov
Copy link
Contributor Author

ping @wongma7
for review/approval

@ialidzhikov
Copy link
Contributor Author

ping @wongma7
for review/approval

@ialidzhikov
Copy link
Contributor Author

/assign @nckturner

@ialidzhikov
Copy link
Contributor Author

ping @wongma7 @nckturner

@wongma7
Copy link
Contributor

wongma7 commented Dec 13, 2021

/lgtm
/approve

sorry for delay, I wanted to get v2.4.0 pushed to private ECR as well to keep the GCR and ECR kustomize in sync. Now the ECR public kustomize will drift out of sync anyway so ultimately I don't think it matters much if the templates go out of sync...as long as they are the same major version

~ $ aws ecr get-login-password | docker login --username AWS --password-stdin 602401143452.dkr.ecr.us-west-2.amazonaws.com
    docker pull 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/livenessprobe:v2.4.0

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@wongma7
Copy link
Contributor

wongma7 commented Dec 13, 2021

ref, table of sidecar image availability for ecr/ecr public: #1136 (comment)

@k8s-ci-robot k8s-ci-robot merged commit 3b308fd into kubernetes-sigs:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Warning" LogLevel for LivenessProbe
5 participants