Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart should default enableVolumeScheduling: true #727

Closed
aaroniscode opened this issue Feb 5, 2021 · 2 comments · Fixed by #752
Closed

Helm chart should default enableVolumeScheduling: true #727

aaroniscode opened this issue Feb 5, 2021 · 2 comments · Fixed by #752
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@aaroniscode
Copy link

/kind bug

What happened?
Deployed the default helm chart and topology aware dynamic provisioning did not work. The kustomize based manifest default to true: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/deploy/kubernetes/values/controller.yaml#L4

What you expected to happen?
With the CSI Topology sub-feature at GA status, I would expect this feature gate to default to true.

Thoughts on this? Is there still a good reason to default the Helm chart to not use the Topology feature?

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 16, 2021

Agreed we can default to true.

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ayberk:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Agreed we can default to true.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 16, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants