Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOPS parameter bug when no volume type is defined #1236

Merged
merged 1 commit into from
May 13, 2022

Conversation

torredil
Copy link
Member

@torredil torredil commented May 13, 2022

Signed-off-by: Eddie Torres torredil@amazon.com

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

  • The IOPS parameter, defined in the StorageClass.parameters, is not picked up by the driver when the volume type is not defined (i.e. defaults to gp3).

Steps to Reproduce

  • Create a StorageClass without a volume type but with IOPS
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: test
parameters:
  iops: "6000"
provisioner: ebs.csi.aws.com
  • Provision a volume with this StorageClass.
k apply -f claim.yaml
  • You'll see that the IOPS values is not honored in the volume created.
 % aws ec2 describe-volumes --volume-id vol-085b747b34dd7f330 --query 'Volumes[0].[Iops, VolumeType]'
[
    3000,
    "gp3"
]

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@gtxu
Copy link
Contributor

gtxu commented May 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 52479eb into kubernetes-sigs:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOPS parameters is not picked up by driver without defining volume type
4 participants