Update documentation #1263
Merged
Update documentation #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
torredil
removed
the
approved
rdpsin
reviewed
Jun 6, 2022
docs/parameters.md
Outdated
| @@ -0,0 +1,17 @@ | |||
| # CreateVolume Parameters | |||
| There are several optional parameters that could be passed into `CreateVolumeRequest.parameters` map, these parameters can be configured in StorageClass, see [example](../examples/kubernetes/storageclass): | |||
There was a problem hiding this comment.
How about adding a reference to the SC tagging doc here as well?
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
wmesard
reviewed
Jun 6, 2022
Signed-off-by: Eddie Torres <torredil@amazon.com>
k8s-ci-robot
removed
the
lgtm
|
@wmesard Appreciate the feedback, new rev addresses all of your comments. |
ghost
approved these changes
Jun 7, 2022
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wmesard
approved these changes
Jun 7, 2022
| * Enable flag `--allow-privileged=true` for `kubelet` and `kube-apiserver` | ||
| * Enable `kube-apiserver` feature gates `--feature-gates=CSINodeInfo=true,CSIDriverRegistry=true,CSIBlockVolume=true,VolumeSnapshotDataSource=true` | ||
| * Enable `kubelet` feature gates `--feature-gates=CSINodeInfo=true,CSIDriverRegistry=true,CSIBlockVolume=true` | ||
| * If you intend to use the csi-snapshotter functionality you will need to first install the [CSI Snapshotter](https://github.com/kubernetes-csi/external-snapshotter) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MurphyPuppy, rdpsin, torredil, wmesard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: torredil torredil@amazon.com
What is this PR about? / Why do we need it?
Current project documentation is not very user-friendly, hard to navigate, and in some instances outdated (a la #1256).
README.mdCONTRIBUTING.mdNOTICEinstall.md,options.md,parameters.md,tagging.md