-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ./ecr-public is a base not a resource #1538
Conversation
|
Welcome @dim-ops! |
Hi @dim-ops. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/close
You likely need to update your kubectl and/or kustomize version. |
@ConnorJC3: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When I try to launch this command
kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master"
or in localkubectl apply -k aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/
I obtain:
error: rawResources failed to read Resources: Load from path ./ecr-public failed: './ecr-public' must be a file (got d='/private/var/folders/fy/d843w2ds1l7gynxsknlfmsc80000gn/T/kustomize-998530352/deploy/kubernetes/overlays/stable/ecr-public')
I propose to replace
resources
bybases
as it is a folderIt works for me after