Batch polling of DescribeVolumesModifications #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
Code Coverage Diff
|
AndrewSirenko
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Holding to avoid merge conflicts for #1963 |
k8s-ci-robot
added
the
do-not-merge/hold
|
Reviewing after PR is rebased post SDK changes. |
Response to my question about when I should expect a review on this PR. |
AndrewSirenko
force-pushed
the
batch-modify
branch
from
f89f3b6
to
0ccce07
Compare
k8s-ci-robot
added
size/XXL
AndrewSirenko
force-pushed
the
batch-modify
branch
2 times, most recently
from
2cfbcb3
to
d167578
Compare
k8s-ci-robot
added
size/L
torredil
reviewed
Apr 1, 2024
AndrewSirenko
force-pushed
the
batch-modify
branch
from
d167578
to
862210c
Compare
AndrewSirenko
force-pushed
the
batch-modify
branch
from
862210c
to
9f64d48
Compare
k8s-ci-robot
added
size/XXL
AndrewSirenko
force-pushed
the
batch-modify
branch
from
9f64d48
to
5cca843
Compare
k8s-ci-robot
added
size/L
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Coalesces EC2 DescribeVolumesModifications (DVM) polling across ControllerExpandVolume/ControllerModifyVolume/ModifyVolume RPCs by volumeID.
This decreases the likelihood of being exceeding one's Non-mutating API request token limit when modifying many volumes at once, which may impact all driver RPCs (ie being throttled for making too manyDescribe* calls).
Note: We do not batch any DVM call that we are unsure if a volume modification has been made for, due to undocumented behavior of a an error being returned if any volume queried for has never been modified.
What testing is done?
CI
Rested that VAC based modify volume batches DescribeVolumeModifications at scale. See Data/Impact section below.
Data/Impact
900 Modified PVCs over 60 seconds across 52 nodes (100Gi increase)
Note: All examples included 900 non-batchable DescribeVolumesModification calls.
200 Modified PVCs over 60 seconds across 12 nodes (100Gi increase)
Note: Both examples include 200 non-batchable DescribeVolumesModification calls.