-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminationGracePeriodSeconds as a helm parameter #2060
Add terminationGracePeriodSeconds as a helm parameter #2060
Conversation
Welcome @ElijahQuinones! |
Hi @ElijahQuinones. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Looks like our PR template was overridden for some reason. Would you change your PR description to answer the following questions?
As well as show evidence that this change worked underneath the Thank you and congrats on submitting your first PR to our repo! |
Will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running make update
will auto-generate the updated Kustomize files and fix the pull-aws-ebs-csi-driver-verify
job.
Tip: I find running the following makefile targets to be quite helpful before publishing a PR to catch these errors in advance:
make update && make verify && make test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run make update
like Eddie said, otherwise lgtm
/label tide/merge-method-squash
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Coverage DiffThis PR does not change the code coverage |
/lgtm |
Is this a bug fix or adding new feature?
This is adding a new feature.
What is this PR about? / Why do we need it?
This PR gives the customer the ability to change their EBS CSI Node Pod termination grace period.
What testing is done?
I ran helm locally on my dev cluster with a
--set node.terminationGracePeriodSeconds=34
and with no terminationGracePeriodSecounds parameter and could see that with no parameter terminationGracePeriodSecounds was set to 30 on my pods and with the
--set node.terminationGracePeriodSeconds=34 i could see that terminationGracePeriodSeconds on my pod was 34 seconds