Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminationGracePeriodSeconds as a helm parameter #2060

Conversation

ElijahQuinones
Copy link
Contributor

@ElijahQuinones ElijahQuinones commented Jun 11, 2024

Is this a bug fix or adding new feature?

This is adding a new feature.

What is this PR about? / Why do we need it?

This PR gives the customer the ability to change their EBS CSI Node Pod termination grace period.

What testing is done?

I ran helm locally on my dev cluster with a

--set node.terminationGracePeriodSeconds=34

and with no terminationGracePeriodSecounds parameter and could see that with no parameter terminationGracePeriodSecounds was set to 30 on my pods and with the
--set node.terminationGracePeriodSeconds=34 i could see that terminationGracePeriodSeconds on my pod was 34 seconds

Screenshot 2024-06-11 at 11 40 41 AM

Screenshot 2024-06-11 at 9 46 25 AM

Copy link

linux-foundation-easycla bot commented Jun 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ElijahQuinones!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ElijahQuinones. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 11, 2024
@AndrewSirenko
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2024
@AndrewSirenko
Copy link
Contributor

AndrewSirenko commented Jun 11, 2024

Looks like our PR template was overridden for some reason. Would you change your PR description to answer the following questions?

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

As well as show evidence that this change worked underneath the what testing is done section.

Thank you and congrats on submitting your first PR to our repo!

@ElijahQuinones
Copy link
Contributor Author

ElijahQuinones commented Jun 11, 2024

Looks like our PR template was overridden for some reason. Would you change your PR description to answer the following questions?

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

As well as show evidence that this change worked underneath the what testing is done section.

Thank you and congrats on submitting your first PR to our repo!

Will do

@ElijahQuinones ElijahQuinones changed the title Added terminationGracePeriodSeconds as a helm parameter Add terminationGracePeriodSeconds as a helm parameter Jun 11, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running make update will auto-generate the updated Kustomize files and fix the pull-aws-ebs-csi-driver-verify job.

Tip: I find running the following makefile targets to be quite helpful before publishing a PR to catch these errors in advance:

make update && make verify && make test

charts/aws-ebs-csi-driver/templates/_node.tpl Show resolved Hide resolved
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run make update like Eddie said, otherwise lgtm
/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@AndrewSirenko
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit d5dd8cf into kubernetes-sigs:master Jun 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants