Backout VAC auto-enable #2118
Merged
Backout VAC auto-enable #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication feature" This reverts commit 4d14b6d.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
This reverts commit f79a3e1.
k8s-ci-robot
added
the
lgtm
Code Coverage Diff
|
AndrewSirenko
approved these changes
Aug 16, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Revert of #2114
What is this PR about? / Why do we need it?
Based on testing, we don't want to auto-enable VAC until the sidecars we ship with the driver support beta API version instead of alpha. We expect that to happen in the next upstream external-resizer/external-provisioner releases but not before our August release.
What testing is done?
N/A