Fix small papercuts

[ConnorJC3]

Is this a bug fix or adding new feature?

Bug fix, mostly

What is this PR about? / Why do we need it?

Fixes three small papercuts:

Cleanup TestNameAllocatorLikelyBadName to prevent code coverage flapping

This should prevent code coverage constantly flapping on this test by properly setting up the existingNames map. Also, added some comments to make the test more clear.

Adjust TestExpiringCache timeouts to decrease CI flakes

This test flakes all the time in CI, especially on the Windows unit tests. I bumped up the sleeps to hopefully combat this, it's set to run in parallel so shouldn't make a significant difference to overall test time.

Standardize deployment methods by removing Kustomize-specific changes

Our helm chart contains two places that are used to magically inject comments into the Kustomize deployment. Remove these to standardize the chart and because they're bad:

• In controller.yaml, the Kustomize deployment comments out the mode by default, thus running the driver in All mode and running the node server on the controller. This is pointless, wastes RAM and CPU, and increases the attack surface.

• In serviceaccount-csi-controller.yaml, the Kustomize deployment has a comment about IRSA. Documenting via comments in the manifests is a horrible practice, EKS Pod Identity is superior to and largely replaces IRSA, and the EKS docs already appropriately document how to use IRSA.

What testing is done?

CI/Manual

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connorjc3. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@ConnorJC3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-ebs-csi-driver-unit	258b99d	link	true	/test pull-aws-ebs-csi-driver-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.