Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart repo index.yaml to contain all currently available chart versions #623

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

krmichel
Copy link
Contributor

@krmichel krmichel commented Nov 27, 2020

Is this a bug fix or adding new feature?
This is a temporary bug fix to get all of the available chart versions into the chart repository
What is this PR about? / Why do we need it?
Currently the index.yaml for the chart repo is being maintained by hand and is out of date. This will update the index to contain all currently available chart versions.
What testing is done?
I have tested the index.yaml from my own chart repository.

I will create another PR to automatically manage the chart repository on pushes when it is updated. This PR needs merged first so when the other change is made it has a correct index.yaml to merge updates into.

fixes #557
fixes #587
fixes #617

krmichel and others added 3 commits November 26, 2020 23:42
Signed-off-by: krmichel <krmichel@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2020
@krmichel
Copy link
Contributor Author

This also supersedes PR #620

@krmichel krmichel mentioned this pull request Nov 27, 2020
@krmichel
Copy link
Contributor Author

@leakingtapan This PR should temporarily fix the index.yaml in the chart repository being out of date. I will create another PR shortly to deal with it in an automated fashion, but this PR will need merged first by at least enough time for the github pages page to update.

@krmichel
Copy link
Contributor Author

PR #624 Should deal with the index.yaml moving forward, but shouldn't be merged until after this PR is merged and the new index.yaml is showing up in the repo.

index.yaml Show resolved Hide resolved
@wongma7
Copy link
Contributor

wongma7 commented Dec 2, 2020

/approve
/ok-to-test

Just one commnet about the kubeVersion field

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2020
@krmichel
Copy link
Contributor Author

krmichel commented Dec 2, 2020

@wongma7 I replied to your comment about the kube version. If we can get this merged I will fix it in my other PR. If I fix it before this gets merged then my index.yaml for this PR will get updated to have 0.6.2 pointing at the wrong release (it would be the one from my fork)

@wongma7
Copy link
Contributor

wongma7 commented Dec 2, 2020

hmmm OK, merging this then!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@wongma7
Copy link
Contributor

wongma7 commented Dec 2, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krmichel, wongma7
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krmichel
Copy link
Contributor Author

krmichel commented Dec 2, 2020

@wongma7 I am not sure why but your approve doesn't seem to have added the label that the bot wants

@wongma7
Copy link
Contributor

wongma7 commented Dec 3, 2020

I think it's because there is no OWNERS file in this branch, no worries, I can manually merge.

@wongma7 wongma7 merged commit 4dfe5df into kubernetes-sigs:gh-pages Dec 3, 2020
krmichel added a commit to krmichel/aws-ebs-csi-driver that referenced this pull request Dec 3, 2020
krmichel added a commit to krmichel/aws-ebs-csi-driver that referenced this pull request Dec 3, 2020
krmichel added a commit to krmichel/aws-ebs-csi-driver that referenced this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants